[PATCH] discovery: if push adds a bookmark, suggest push -B

Matt Mackall mpm at selenic.com
Sat Sep 12 17:31:01 CDT 2015


On Thu, 2015-09-10 at 09:30 -0400, Augie Fackler wrote:
> On Wed, Sep 09, 2015 at 10:24:28PM -0500, timeless at mozdev.org wrote:
> > # HG changeset patch
> > # User timeless at mozdev.org
> > # Date 1441854648 14400
> > #      Wed Sep 09 23:10:48 2015 -0400
> > # Node ID f2bf8ab52b065e46f4fbd4a268ad4c3bb351fee3
> > # Parent  ea489d94e1dc1fc3dc1dcbef1c86c18c49605ed1
> > discovery: if push adds a bookmark, suggest push -B
> 
> I think I don't like this - users might just follow the suggestion and
> add the divergent head, which might be the wrong thing. For example, I
> have a clone of Mercurial that I do all of my work in, but that I also
> use to push to clowncopter. I have a number of bookmarks not yet ready
> for pushing, but this would change the tip to encourage me to do just
> that without reading and understanding what I'm doing.
> 
> Does that worry make sense to anyone else?

I think we have sufficient experience with push -f to think this
particular implementation is a bad idea. A large subset of people will
reach for the nearest hammer you wave at them, without worrying whether
it's the right answer.

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list