[PATCH] tests: add coverage to ensure Wix tracks 'help' and 'templates' files

[Pierre-Yves David]

On 09/14/2015 05:03 PM, Matt Harbison wrote:
> On Mon, 14 Sep 2015 19:39:44 -0400, Pierre-Yves David
> <pierre-yves.david at ens-lyon.org> wrote:
>
>>
>>
>> On 09/13/2015 08:08 PM, Matt Harbison wrote:
>>> # HG changeset patch
>>> # User Matt Harbison <matt_harbison at yahoo.com>
>>> # Date 1442199291 14400
>>> #      Sun Sep 13 22:54:51 2015 -0400
>>> # Node ID 1894c23c325b0241ca3b01450bb38fc3ce544dd4
>>> # Parent  433e55099cfd7c391b4428d62f1c74e76a2133b3
>>> tests: add coverage to ensure Wix tracks 'help' and 'templates' files
>>
>> neat, but I get the following failure:
>>
>> --- /home/pyd/src/mercurial-dev/tests/test-install.t
>> +++ /home/pyd/src/mercurial-dev/tests/test-install.t.err
>> @@ -93,6 +93,7 @@
>>     $ python wixxml.py help
>>     Not installed:
>>       help/common.txt
>> +    help/config.txt.orig
>>       help/hg.1.txt
>>       help/hgignore.5.txt
>>       help/hgrc.5.txt
>>
>> would you make that resistant to .orig?
>
> I guess I should figure out how to invoke 'hg files mercurial/help' and
> convert that output to a list, but this was easier.  Or do you think
> *.orig is going to account for such an overwhelming percentage of the
> extra noise that it is OK to special case *.orig and skip the other
> .hgignore stuff?

I would be okay, if you only skip .orig file because we -know- there 
will be some. You get a chocolate medal if you build a generic version.


-- 
Pierre-Yves David