[PATCH 2 of 2] paper, coal: replace .sourcelast with .bottomline that does the same

Anton Shestakov av6 at dwimlabs.net
Tue Sep 15 03:24:22 CDT 2015


On Mon, 14 Sep 2015 16:51:26 -0700
Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:

> 
> 
> On 09/14/2015 05:42 AM, Anton Shestakov wrote:
> > # HG changeset patch
> > # User Anton Shestakov <av6 at dwimlabs.net>
> > # Date 1442227269 -28800
> > #      Mon Sep 14 18:41:09 2015 +0800
> > # Node ID 59eb92712fe4065633bd0254b3dd7aa761a24f90
> > # Parent  4ac7b7cfe6ff540b0993c1a13c0afd4bac63f725
> > paper, coal: replace .sourcelast with .bottomline that does the same
> 
> trusting you on this series.
> 
> Is there a way we could improve "code" sharing between the two? or
> have some flashy warning if they diverge?
> 

I'm thinking of doing something like what Jordi did in 7c324f65e4ef,
i.e. use %include in coal/map. Then we probably could isolate changes
in style-coal.css and use it in addition to style-paper.css, maybe.

But essentially, showing a flashy warning is better done by the people
reviewing changes. Even if coal reuses map file and css styles from
paper, any change to the templates in paper then will need reviewing,
or rather just viewing, with human eyes in coal as well. Unless you
want to drag some pixel-testing browser plugin/thingy into hg tests.

In other words, I think taking a look at any changes in both paper and
coal and/or reminding contributors that the two styles are heavily
connected is the easiest way to deal with this. (At least if I ever get
to doing what the first paragraph proposes).


More information about the Mercurial-devel mailing list