[PATCH] dispatch: stop warning about EPIPE in --debug mode

Daniel Colascione (SEATTLE) dancol at fb.com
Thu Sep 24 02:24:24 CDT 2015


# HG changeset patch
# User Daniel Colascione <dancol at fb.com>
# Date 1443078937 -10800
#      Thu Sep 24 10:15:37 2015 +0300
# Node ID ef903d0c1928d9409640485e0908beb40414fe7a
# Parent  60558319ce724e8377c56591af3089380753f6de
dispatch: stop warning about EPIPE in --debug mode

It seems silly for "hg --debug manifest | less" to print a scary
message after the user hits "q" in less.  hg should just exit silently
instead, since EPIPE on stdout is a perfectly reasonable result.

diff --git a/mercurial/dispatch.py b/mercurial/dispatch.py
--- a/mercurial/dispatch.py
+++ b/mercurial/dispatch.py
@@ -292,8 +292,7 @@
             ui.warn(_("abort: error: %s\n") % reason)
         elif (util.safehasattr(inst, "args")
               and inst.args and inst.args[0] == errno.EPIPE):
-            if ui.debugflag:
-                ui.warn(_("broken pipe\n"))
+            pass
         elif getattr(inst, "strerror", None):
             if getattr(inst, "filename", None):
                 ui.warn(_("abort: %s: %s\n") % (inst.strerror,
inst.filename))
@@ -310,10 +309,7 @@
         try:
             ui.warn(_("interrupted!\n"))
         except IOError as inst:
-            if inst.errno == errno.EPIPE:
-                if ui.debugflag:
-                    ui.warn(_("\nbroken pipe\n"))
-            else:
+            if inst.errno != errno.EPIPE:
                 raise
     except MemoryError:
         ui.warn(_("abort: out of memory\n"))



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20150924/3e882a15/attachment.pgp>


More information about the Mercurial-devel mailing list