[PATCH 2 of 4] lock: move acquirefn call to inside the lock

[Pierre-Yves David]

On 09/23/2015 11:47 AM, Siddharth Agarwal wrote:
> On 9/23/15 2:05 AM, Pierre-Yves David wrote:
>>
>>
>> On 09/22/2015 05:15 PM, Siddharth Agarwal wrote:
>>> # HG changeset patch
>>> # User Siddharth Agarwal <sid0 at fb.com>
>>> # Date 1442956182 25200
>>> #      Tue Sep 22 14:09:42 2015 -0700
>>> # Node ID c10a294cdec22c49568da7863745085b19d846f7
>>> # Parent  37e382191204560e2cdd8e616c0022907c4f6aa7
>>> lock: move acquirefn call to inside the lock
>>>
>>> We're going to need to call it again as part of reinitialization after a
>>> subprocess inherits the lock.
>>
>> My pinky is telling me that we are about to introduce easy way to
>> create reference cycle. What's your plan in this regard?
>
> As mentioned on IRC:
> - this patch itself introduces no new cycles
> - acquirefn could theoretically be used to introduce a cycle, but so
> could the releasefn parameter, which already exists. So we're not making
> things worse.

Okay, then patches 1-2 have been pushed to the clowncopter.

>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel

-- 
Pierre-Yves David