[PATCH V5] mercurial: add debugextensions command (issue4676)

Matt Mackall mpm at selenic.com
Thu Sep 24 14:46:50 CDT 2015


On Thu, 2015-09-24 at 15:10 -0400, timeless wrote:
> > +def debugextensions(ui, **opts):
> 
> > +        if ui.quiet or ui.verbose:
> > +            fm.write('name', '%s\n', extname)
> > +        else:
> > +            fm.write('name', '%s', extname)
> > +            if not exttestedwith:
> > +                fm.plain(_(' (untested!)\n'))
> > +            else:
> > +                if exttestedwith == ['internal'] or \
> > +                                util.version() in exttestedwith:
> > +                    fm.plain('\n')
> > +                else:
> > +                    lasttestedversion = exttestedwith[-1]
> 
> this should have _():
> > +                    fm.plain(' (%s!)\n' % lasttestedversion)
> 
> a localization could use ` [%s]`, or need RTL markers, or various other things.

These particular l10n concerns are not ones we've cared about to date,
so I don't think they should be a barrier to review. Check-code actually
ignores non-textual strings for i18n warnings intentionally.

I'm having a pretty hard time imagining why a translator would ever
change () to [], even if [] was more conventional. Consistency with
Mercurial formatting and documentation should trump local convention.
But currently there's none of that in our translations.

Nor are we anywhere close to being able to support RTL languages
properly. As far as I can tell, there's actually no consensus on how to
do this for terminal apps and I think at least Debian and Ubuntu
translation teams have decided to punt on the issue and not translate
RTL languages on the terminal at all. 

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list