[Bug 4843] New: if commit template is not changed, commit should abort

mercurial-bugs at selenic.com mercurial-bugs at selenic.com
Thu Sep 24 21:17:18 UTC 2015


http://bz.selenic.com/show_bug.cgi?id=4843

            Bug ID: 4843
           Summary: if commit template is not changed, commit should abort
           Product: Mercurial
           Version: earlier
          Hardware: PC
                OS: Windows
            Status: UNCONFIRMED
          Severity: feature
          Priority: wish
         Component: Mercurial
          Assignee: bugzilla at selenic.com
          Reporter: rm at fb.com
                CC: mercurial-devel at selenic.com

With a committemplate defined, if we start a commit and exit the editor without
saving, the commit is successful and the template is used as the commit
message.

Without the committemplate the user not saving leads to an empty commit message
and aborts. This sounds like a user-friendly and intuitive way to abort the
commit: "not saving aborts".

This logic should probably apply to the committemplate case as well. If no
change/save is made to the default template, the commit should abort. That
would be similar to the check=changed configuration for merge-tools.

(However, there might be case were we would not want that? When the commit
template is used to generate all useful information -- in that case should we
prompt?)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Mercurial-devel mailing list