[Bug 4870] New: copies.pathcopies does not use matcher when operating on the working copy

[mercurial-bugs at selenic.com]

https://bz.mercurial-scm.org/show_bug.cgi?id=4870

            Bug ID: 4870
           Summary: copies.pathcopies does not use matcher when operating
                    on the working copy
           Product: Mercurial
           Version: 3.5.1
          Hardware: PC
                OS: Linux
            Status: UNCONFIRMED
          Severity: bug
          Priority: wish
         Component: Mercurial
          Assignee: bugzilla at selenic.com
          Reporter: julianbrunner at gmail.com
                CC: mercurial-devel at selenic.com

It seems to me that copies.pathcopies does not use its matcher parameter in
some cases. For instance, _forwardcopies has a shortcut in the case that
revision b is the working copy. This shortcut does not use the matcher at all.
In this case, the functions returns all copies in the entire working copy.

As far as I know, this does not manifest itself in the (semantic) behavior of
any mercurial command, since both status and diff only access the information
returned by pathcopies w.r.t. files that were already matched on. However, I
feel that this makes the pathcopies function behave unexpectedly, which can
lead to bugs in code using this function.

-- 
You are receiving this mail because:
You are on the CC list for the bug.