[PATCH evolve-ext] evolve: do not set experimental.evolution in uisetup

Pierre-Yves David pierre-yves.david at ens-lyon.org
Sun Apr 3 16:01:33 EDT 2016



On 04/02/2016 05:02 PM, Jun Wu wrote:
> # HG changeset patch
> # User Jun Wu <quark at fb.com>
> # Date 1459641729 -3600
> #      Sun Apr 03 01:02:09 2016 +0100
> # Node ID eb063ecaef4c50fb50f6f21dd04b087cf1ac35b4
> # Parent  45b2b59ce5d3a8641814107c7fc0808a361a8f30
> evolve: do not set experimental.evolution in uisetup
>
> Before this patch, evolve will set experimental.evolution=all if it's empty.
> This does not work well with chg, since chg only runs uisetup once and will
> copy configs modified by extensions when loading new ui unconditionally.
>
> In this case, if the user starts a chgserver with empty experimental.evolution,
> evolve will set it to "all" and the user will lose changes to set it to other
> value.
>
> This patch addressed the issue by replacing ui.setconfig with a default value
> at reading time (ui.configlist).

I don't think this will work. There is third party code (especially… 
mercurial core) that rely on the extension to set this when enabled. And 
I assume this would break it all.

I this time for a field test of the extensibility of chg config dispatch?

Cheers,

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list