[PATCH evolve-ext] touch: make sure the new noise number is different from the old one

Jun Wu quark at fb.com
Sun Apr 3 19:01:00 EDT 2016


On 04/03/2016 09:46 PM, Pierre-Yves David wrote:
> This changeset fix a 1 in 2³² bugs (so it is still useful) but hide this
> failure because the test are not checking this specific scenario.

Yes. As discussed in IRC. This patch does not solve all the issues.
But fixing all of them seems to be impossible to do efficiently.

> Can you send a V2 with a test added for the still problematic case? I would
> like to make sure we can check it is fixed in chg.

Since it's impossible to solve the issue without adding notable overhead, I'm
going to drop this one. Then the existing test will catch chg randomness issue.


More information about the Mercurial-devel mailing list