[PATCH 5 of 7] docchecker: refactor check

timeless timeless at mozdev.org
Mon Apr 4 05:31:31 EDT 2016


# HG changeset patch
# User timeless <timeless at mozdev.org>
# Date 1456975964 0
#      Thu Mar 03 03:32:44 2016 +0000
# Node ID 3f37daec9b438013c6192e128bca472b6ec944e9
# Parent  1645eabe1a4e8a22613d49f1caf1263db5b3f7a2
docchecker: refactor check

diff --git a/doc/docchecker b/doc/docchecker
--- a/doc/docchecker
+++ b/doc/docchecker
@@ -10,16 +10,23 @@
 import re
 
 leadingline = re.compile(r'(^\s*)(\S.*)$')
-hg_backtick = re.compile(r""":hg:`[^`]*'[^`]*`""")
-hg_cramped = re.compile(r'\w:hg:`')
+
+checks = [
+  (r""":hg:`[^`]*'[^`]*`""",
+    """warning: please avoid nesting ' in :hg:`...`"""),
+  (r'\w:hg:`',
+    'warning: please have a space before :hg:'),
+]
 
 def check(line):
-    if hg_backtick.search(line):
+    messages = []
+    for match, msg in checks:
+        if re.search(match, line):
+            messages.append(msg)
+    if len(messages):
         print(line)
-        print("""warning: please avoid nesting ' in :hg:`...`""")
-    if hg_cramped.search(line):
-        print(line)
-        print('warning: please have a space before :hg:')
+        for msg in messages:
+            print(msg)
 
 def work(file):
     (llead, lline) = ('', '')


More information about the Mercurial-devel mailing list