[PATCH v5] Allow commit date before Unix epoch, clean fix for (issue2513)

Adrian Buehlmann adrian at cadifra.com
Mon Apr 4 07:45:04 EDT 2016


On 2016-04-04 12:59, Florent Gallaire wrote:
> 2016-04-04 9:07 GMT+02:00 Adrian Buehlmann <adrian at cadifra.com>:
>> Reviewers usually don't do the work for contributers (they are busy
>> enough already).
> 
> I really think it's unfair since:
> 1) You know what ? I'm busy enough already too
> 2) I'm not paid thousands of dollars a month by Facebook or other to
> work on Mercurial
> 3) I have fixed THREE buggy commits that were good enough to be in
> Mercurial for six years.
> 
>> Having it tested in the testsuite is better.
> 
> I agree with you, but it has never been done before and it was not a
> problem until now.

Ok. Perhaps I can hack up some test changes and resend them together
with your patch as a series.

My mercurial dev environment (and knowledge) is a bit outdated though...
(I've been trying to keep away from mercurial hacking for a while now).

Just leave things as they are if you don't have time.


More information about the Mercurial-devel mailing list