[PATCH rfc] rfc: call gc at exit of mercurial

Yuya Nishihara yuya at tcha.org
Tue Apr 5 09:59:09 EDT 2016


On Tue, 5 Apr 2016 00:10:17 -0700, Pierre-Yves David wrote:
> However, the good news is that we don't corrupt or loose anything in 
> (2). We just leave the repo into an unrecovered state that people can 
> recover with `hg recover`, so buggy code/situation expose slightly more 
> anoying behavior. This is probably fine. (There might be some super old 
> third party extension that will need to update itself).
> 
> someone should have a look at the other __del__ behavior and see if they 
> have as "harmless" behavior (eg: lock.__del__ would leave the repository 
> locked, but next run will remove that lock at the process is dead)

A failure case of atomictempfile would leave garbage, which is why I've
accepted gc.collect() patch for chg, 5346e9b910fc. But leaving garbage could
be considered "harmless".


More information about the Mercurial-devel mailing list