[PATCH 1 of 7] graft: use double quotes for arguments

Matt Harbison mharbison72 at gmail.com
Tue Apr 5 22:51:10 EDT 2016


On Mon, 04 Apr 2016 11:48:50 -0400, Martin von Zweigbergk via  
Mercurial-devel <mercurial-devel at mercurial-scm.org> wrote:

> On Mon, Apr 4, 2016 at 2:31 AM, timeless <timeless at mozdev.org> wrote:
>> # HG changeset patch
>> # User timeless <timeless at mozdev.org>
>> # Date 1452591024 0
>> #      Tue Jan 12 09:30:24 2016 +0000
>> # Node ID e98a5f3fac5f0fd72fbf38bc410a55a97790fa31
>> # Parent  ff0d3b6b287f89594bd8d0308fe2810d2a18ea01
>> graft: use double quotes for arguments
>
> Where's the motivation for this? Was there some discussion elsewhere?
> Is this one of few outliers (so this is for consistency)?

You can't use single quotes in cmd.exe.  See be7ef03d7fb6.  I didn't  
methodically look for other problems at the time.

>>
>> diff --git a/mercurial/commands.py b/mercurial/commands.py
>> --- a/mercurial/commands.py
>> +++ b/mercurial/commands.py
>> @@ -4026,7 +4026,7 @@
>>
>>        - show revisions sorted by date::
>>
>> -          hg log -r 'sort(all(), date)'
>> +          hg log -r "sort(all(), date)"
>>
>>      See :hg:`help revisions` and :hg:`help revsets` for more about
>>      specifying revisions.
>> _______________________________________________
>> Mercurial-devel mailing list
>> Mercurial-devel at mercurial-scm.org
>> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list