[PATCH 5 of 5] revset: remove unused lookup argument from _tokenizealias()
mpm at selenic.com
Wed Apr 6 16:10:13 EDT 2016
On Wed, 2016-04-06 at 21:19 +0900, Yuya Nishihara wrote:
> On Tue, 05 Apr 2016 13:51:51 -0500, Matt Mackall wrote:
> > On Wed, 2016-03-30 at 00:27 +0900, Yuya Nishihara wrote:
> > > # HG changeset patch
> > > # User Yuya Nishihara <yuya at tcha.org>
> > > # Date 1456728392 -32400
> > > # Mon Feb 29 15:46:32 2016 +0900
> > > # Node ID cf9abced341da9a63ad5daf49a908d39795aafb5
> > > # Parent 092c90f4dad4e4e5870499819d4c0a2f4646e8fd
> > > revset: remove unused lookup argument from _tokenizealias()
> > >
> > > Since aliases are defined in configuration file, they should never have
> > > tokens
> > > that require a repository-dependent lookup function.
> > That's not obvious to me.
> > It seems that if I have a branch named i-love-hyphens, and I can do:
> > $ hg log -r "i-love-hyphens% and author(mpm)"
> > ..then I should be able to turn that into a revset alias without having to
> > change the quoting, right?
> Yeah, that should be possible. _tokenizealias() is the tokenizer for alias
And I'm suggesting that the problematic branch name is -in- the alias. We can't
tokenize the alias correctly without knowing that "i-love-hyphens" is a valid
token.. and that requires a repo containing that token.
> This patch just removed an unused argument. There should be no behavior
Ok, but if the current behavior is buggy because it should be using the arg,
then it's not really a cleanup.
Mathematics is the supreme nostalgia of our time.
More information about the Mercurial-devel