[PATCH 7 of 7] check-code: reject import cStringIO
timeless
timeless at mozdev.org
Wed Apr 6 17:57:44 EDT 2016
# HG changeset patch
# User timeless <timeless at mozdev.org>
# Date 1459974914 0
# Wed Apr 06 20:35:14 2016 +0000
# Node ID 670b4e0794aebc10df2298a7bea28a9135589beb
# Parent 5d3336fefe3a4df0f907980361be7c5b3947eab3
check-code: reject import cStringIO
please use the util.stringio alias instead
diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -316,6 +316,7 @@
(r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),
(r'\butil\.Abort\b', "directly use error.Abort"),
(r'^import Queue', "don't use Queue, use util.queue + util.empty"),
+ (r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"),
],
# warnings
[
More information about the Mercurial-devel
mailing list