[PATCH 5 of 7] docchecker: refactor check

Martin von Zweigbergk martinvonz at google.com
Wed Apr 6 18:12:25 EDT 2016


On Wed, Apr 6, 2016 at 3:02 PM, timeless <timeless at gmail.com> wrote:
> Martin von Zweigbergk wrote:
>> It seems like more than a refactoring to me. If I'm reading it right,
>> if a line had two errors, it would print:
>>
>> line with error
>> error 1
>> line with error
>> error 2
>>
>> After this patch:
>>
>> line with error
>> error 1
>> error 2
>>
>> Correct? I think the new output is good, but the patch shouldn't have
>> been disguised as a refactoring.
>
> Sorry. I meant that it refactored the reporting, not the code.
>
> There's probably a better way to write it than what I wrote... Please
> feel free to fix in flight.

I'll change it to "docchecker: report context line at most once".


More information about the Mercurial-devel mailing list