[PATCH hglib] Drop support for python 2.4 and 2.5, as is core hg

[Gregory Szorc]

On Wed, Apr 6, 2016 at 9:44 AM, Augie Fackler <raf at durin42.com> wrote:

> On Wed, Apr 06, 2016 at 03:34:30PM +0200, Axel Hecht wrote:
> > On 06/04/16 15:25, Matt Mackall wrote:
> > >On Wed, 2016-04-06 at 14:36 +0200, Axel Hecht wrote:
> > >># HG changeset patch
> > >># User Axel Hecht <axel at pike.org>
> > >># Date 1442329051 -7200
> > >>#      Tue Sep 15 16:57:31 2015 +0200
> > >># Node ID 674bd25c2339aa4b2be714b8d763c93c8eb07b36
> > >># Parent  8c4d24b58c23030616d7f65a4ae3a392e8ef9d0d
> > >>Drop support for python 2.4 and 2.5, as is core hg.
> > >The maintenance burden for 2.4 support in hglib is currently zero, so I
> don't
> > >see a reason to do this. If, for some crazy reason, someone has a
> Python2.4-
> > >based hglib app that they don't want to update, they needn't run it
> against a
> > >Python2.4-compatible hg. Since basically every 2.x release required
> fixes in
> > >Mercurial itself, this isn't a particularly unlikely scenario[1].
> > >
> > >On the other hand, if you're planning substantial work on hglib that
> depends on
> > >2.6 features, I'm happy to listen.
> > I removed those based on a conversation I had with gps about other
> patches
> > that I'm about to submit after this.
> >
> https://bitbucket.org/pike/python-hglib/commits/c82671bcb9c61d96cdaa8116a78dd184c18f5e53#comment-1970588
> > was were we discussed this.
> >
> > In this particular case,
> >
> > -        return context.changectx(self, changeid)
> > +        try:
> > +            return context.changectx(self, changeid)
> > +        except ValueError as e:
> > +            raise IndexError(*e.args)
> >
> > only works this way in non-ancient versions of python.
> >
> > The other patches are for
> > https://bz.mercurial-scm.org/buglist.cgi?bug_id=4510,4511,4644, one
> patch
> > each.
> >
> > I didn't mass-submit them all 'cause the wiki said so, but I'm happy to
> send
> > them over for context.
>
> If it's 5 or so patches, feel free to send them all out. If it's
> mostly the exception syntax, I'm not sure that quite justifies
> ditching 2.4 here, but I could be pretty easily persuaded.
>
>
We could benefit from context managers in hglib. As it stands today, it is
relatively easy to forget to close the connection, leaving an orphaned
process.

Also, it would be nice to make hglib compatible with Python 3.5, which
won't be possible as long as we support 2.4/2.5.


> >
> > Axel
> >
> > >
> > >[1] Compare that to the Perl-based db-backed fulltext search engine I
> have
> > >running on my mail server that's been running unattended for about 18
> years.
> > >--
> > >Mathematics is the supreme nostalgia of our time.
> > >
> >
> > _______________________________________________
> > Mercurial-devel mailing list
> > Mercurial-devel at mercurial-scm.org
> > https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160407/e6fa1db4/attachment.html>