[PATCH 3 of 3] test-progress: disable mocking-time tests on chg

[Yuya Nishihara]

On Fri, 8 Apr 2016 17:18:56 +0100, Jun Wu wrote:
> On 04/08/2016 04:23 PM, Yuya Nishihara wrote:
> > test-progress: disable mocking-time tests on chg  
> 
> The series look good to me.
> 
> I think test-progress.t would be fixable by adding MOCKTIME to sensitive
> environment variable. Or, just change it to HGMOCKTIME since that would
> be sensitive to chg. But just skipping them also makes sense.

I've tried HGMOCKTIME, but the problem seemed not that simple, and I stopped
investigation as it wouldn't be worth making this test pass on chg.

> However the API to support change sensitive part of confighash won't arrive
> soon. Originally, I would like to do that in chgserver.py and then with
> devel-warn mentioned by marmoute, it seems the logic to mark which config
> is sensitive is better living in ui.py, config.py instead of chgserver.py.
> 
> But I'm still not sure where to put the API to change sensitive config
> or environment variables. chgserver.py actually makes a lot of sense if
> it is considered "core" because it's the only one requiring the stuff.
> Moving it to files like extensions.py, ui.py or config.py looks over-
> design by me, because I don't think there are future users.
> 
> If "import chgserver" in extensions.py for devel-warn is acceptable,
> I would be happy and just go ahead with adding the sensitive APIs to
> chgserver.py and devel-warn, like http://sf.p.lihdd.net/hg/ff7650bef711.txt

I don't follow the context behind this patch, but some of the problems
detected by _chgcompatcheck would happen on plain command server. That might
justify moving chgserver._configsections somewhere else.

However, the patch seems overly complicated compared to the benefit provided
by it.