[PATCH 3 of 7] check-code: reject import urllib
timeless
timeless at mozdev.org
Mon Apr 11 18:48:57 EDT 2016
# HG changeset patch
# User timeless <timeless at mozdev.org>
# Date 1459989247 0
# Thu Apr 07 00:34:07 2016 +0000
# Node ID 112ca3e0b4f25cf0d3503b93e94e8dba887923c9
# Parent c9d401b42c8777746d7a22346bd10e5c09915696
check-code: reject import urllib
diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -316,6 +316,8 @@
(r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),
(r'\butil\.Abort\b', "directly use error.Abort"),
(r'^import Queue', "don't use Queue, use util.queue + util.empty"),
+ (r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"),
+ (r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"),
],
# warnings
[
More information about the Mercurial-devel
mailing list