[PATCH 3 of 3 V1] shelve: refactor directory name into constant

[Sean Farley]

Kevin Bullock <kbullock+mercurial at ringworld.org> writes:

>> On Apr 7, 2016, at 20:08, Oleg Afanasyev <olegaf at fb.com> wrote:
>> 
>> # HG changeset patch
>> # User Oleg Afanasyev <olegaf at fb.com>
>> # Date 1459888093 25200
>> #      Tue Apr 05 13:28:13 2016 -0700
>> # Node ID 6fc94bf7cc60bada8327676ec14ec08087042cc6
>> # Parent  ab3afe021b6c10820ab8fb28cb04767f17b203fc
>> shelve: refactor directory name into constant
>> 
>> Shelve directory name extracted into constant to avoid typos/duplication.
>
> FWIW, this patch could've been first in the series. Per <https://www.mercurial-scm.org/wiki/ContributingChanges#Organizing_patches>, put the least-controversial changes first in the series.

Yes, I would agree and put this patch first thereby making [PATCH 2] the
last one in the series.

> This series looks good to me. I won't queue because I'm not familiar enough with the implications of shared repos, but you have my +1.

This was a refactor I suggested a while back. Glad to see it here :-)