[PATCH 2 of 2 v2] convert: keep converted hg parents that are outside convert.hg.revs (BC)

Sean Farley sean at farley.io
Tue Apr 12 18:23:55 EDT 2016


Mads Kiilerich <mads at kiilerich.com> writes:

> # HG changeset patch
> # User Mads Kiilerich <madski at unity3d.com>
> # Date 1460499381 -7200
> #      Wed Apr 13 00:16:21 2016 +0200
> # Node ID f7c245a1e550915fca416e76abff626af85e4291
> # Parent  637869e31c974eecea10853fadac216107c434e1
> convert: keep converted hg parents that are outside convert.hg.revs (BC)
>
> Before, when converting revisions without also including their already
> converted parents in convert.hg.revs, the parents would no longer be parents.
>
> That seems unfortunate and we dare to assume that nobody ever wants that.
>
> Instead, preserve parents that are outside the current convert range but
> already have been converted.
>
> The parents returned in getcommit() are unconditionally converted, so we
> introduce a separate optparents with optional parents.

Reading the code, this seems like a pretty straight-forward fix to me.
Perhaps a little extra overhead but that seems negligible here. 


More information about the Mercurial-devel mailing list