[PATCH 2 of 2] obsstore: move delete function from obsstore class to repair module

Pierre-Yves David pierre-yves.david at ens-lyon.org
Wed Apr 13 01:54:27 EDT 2016



On 04/12/2016 12:44 PM, Sean Farley wrote:
> Kostia Balytskyi <ikostia at fb.com> writes:
>
>> # HG changeset patch
>> # User Kostia Balytskyi <ikostia at fb.com>
>> # Date 1460459210 25200
>> #      Tue Apr 12 04:06:50 2016 -0700
>> # Node ID cd55c17037a71173ec5572b32b951f8007ea164f
>> # Parent  33e53380588a5953e3f25d4ff66d1b2e27ec7820
>> obsstore: move delete function from obsstore class to repair module
>>
>>
>> Since one of the original patches was accepted already and people on the
>> mailing list still have suggestions as to how this should be improved, I'm
>> implementing those suggestions in the following patches (this and the ones that
>> might follow).
> Patch 1 looks fine to me. I don't know why people wanted this in
> repair.py instead of obsolete.py but I guess I don't really care one way
> or the either.

Because deleting marker violate the append only principle of our 
storage. So it live right next to repair.strip() who do the same thing 
(stripping content) for changelog.

Cheers,

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list