[PATCH 3 of 3] test-progress: disable mocking-time tests on chg

[Pierre-Yves David]

On 04/09/2016 01:32 PM, Jun Wu wrote:
> On 04/09/2016 09:01 AM, Yuya Nishihara wrote:
>> I've tried HGMOCKTIME, but the problem seemed not that simple, and I
>> stopped investigation as it wouldn't be worth making this test pass 
>> on chg.
>
> Yep. I had tried that (before the sprint) as well. It seems it solves 
> some
> problem but not all. Therefore I'm okay with just skipping them.
> (This is not important anyway. I want to discuss the chg checker 
> script below)
>
>> I don't follow the context behind this patch, but some of the problems
>> detected by _chgcompatcheck would happen on plain command server. That
>> might justify moving chgserver._configsections somewhere else.
>>
>> However, the patch seems overly complicated compared to the benefit
>> provided by it.
>
> My V1 patch is a standalone check-chg-compat script:
> http://patchwork.serpentine.com/patch/14230/
>
> marmoute has rejected that one telling me I should use devel-warn on IRC.
> He marked the patch as "Change Requested" without replying the mail 
> though.
> I somehow agree that we may want devel-warn eventually but it is hard to
> do now because:
>
> 1. devel-warn is enabled for all tests, which means to enable it, we have
> to fix all problematic before the devel-warn patch. To fix all 
> extensions,
> we have to get the whitelist API refactoring.

Actually, not entirely. If fixing all extensions immediatly is too much 
a trouble we could have the devel warning disabled, either by default or 
for specific tests. Fixing them iteratively after than.

This would avoid implementing the feature twice, once in the script, and 
once for the markers. It also increase the chance that we actually end 
up with a devel warning.

-- 
Pierre-Yves David