[PATCH 10 of 14] chg: calculate sockdirfd

Jun Wu quark at fb.com
Wed Apr 13 12:50:57 EDT 2016


On 04/13/2016 04:07 PM, Yuya Nishihara wrote:
> I still think we should avoid unnecessary path manipulation because we have
> to be careful about pitfalls such as CHGSOCKNAME="/silly/basename/..".
> That's why I prefer CHGSOCKDIR.

I still prefer the flexibility. People using ".." should know what they are
doing. I don't think it necessary to prevent people using developer-facing
features from doing wrong. Things like "rm -rf ~" are not protected.


More information about the Mercurial-devel mailing list