[PATCH 13 of 14] chg: extra the logic opening current directory to opencwdx()

Jun Wu quark at fb.com
Wed Apr 13 12:55:55 EDT 2016


On 04/13/2016 04:28 PM, Yuya Nishihara wrote:
> OT: Maybe we can sort out functions that causes hard failure. I mean
> s/fsetcloexec/fsetcloexecx/.

Thanks for reviewing!

I'm a bit busy with internal packing (currently handing mac os x) and I'm
spending some time improving internal tools related to release.

Do you think it's okay to have a marco for all "*x", or "*at" stuff? It will
make the code shorter. Although I'm not a big fan of macros, I think current
code duplication is a bit too much and macro can help.

And about OS X feature detection. What do you think is the best way to do
feature detection here? I personally dislike autoconf. But is compiling
a dummy C program okay? Or should I use "#ifdef SYS_openat"? I think the
C library and system header may not in sync though.


More information about the Mercurial-devel mailing list