[PATCH 2 of 2 v2] convert: keep converted hg parents that are outside convert.hg.revs (BC)

[Yuya Nishihara]

On Thu, 14 Apr 2016 01:07:31 +0200, Mads Kiilerich wrote:
> On 04/13/2016 05:49 PM, Yuya Nishihara wrote:
> >> -        parents = [p.hex() for p in self._parents(ctx)]
> >> +        _parents = self._parents(ctx)
> >> +        parents = [p.hex() for p in _parents]
> >> +        optparents = [p.hex() for p in ctx.parents() if p not in _parents]  
> > One nit. ctx.parents() may contain null revision if p1 is null. Perhaps we'd
> > better filter out it like self._parents().
> >
> > If you agree, I'll change s/if p not in _parents/if p and p not in _parents/
> > in flight.  
> 
> Yeah, seems reasonable. Thanks!
> 
> (It would be weird if the null revision has been converted, so I doubt 
> it makes any actual difference ...)

There's no practical difference as optparets is filtered by converter.map.

Pushed the modified version, thanks.