[PATCH 3 of 3] test-progress: disable mocking-time tests on chg

Sean Farley sean at farley.io
Thu Apr 14 16:34:09 EDT 2016


Pierre-Yves David <pierre-yves.david at ens-lyon.org> writes:

> On 04/13/2016 03:41 AM, Jun Wu wrote:
>> On 04/13/2016 07:42 AM, Pierre-Yves David wrote:
>>> Actually, not entirely. If fixing all extensions immediatly is too 
>>> much a
>>> trouble we could have the devel warning disabled, either by default 
>>> or for
>>> specific tests. Fixing them iteratively after than.
>>
>> How about other issues?
>>
>> 1. Hacking stdlib is ugly
>
> Yes it is. But we don't have a better option, do we? Given that the 
> monkey patch will be temporary and only in the case where devel-warning 
> are enabled, I think this is okay. We do some awful stuff in core from 
> time to time when we don't have better option.

Why can't we have an abstraction in pycompat? e.g.

pycompat.hgiteritems()


More information about the Mercurial-devel mailing list