[PATCH 3 of 3] hook: report untrusted hooks as failure (issue5110) (BC)

Pierre-Yves David pierre-yves.david at ens-lyon.org
Fri Apr 15 14:48:32 EDT 2016



On 04/15/2016 06:26 AM, timeless wrote:
>
>
> On Apr 15, 2016 3:50 AM, "Pierre-Yves David" 
> <pierre-yves.david at ens-lyon.org 
> <mailto:pierre-yves.david at ens-lyon.org>> wrote:
>
> > +                abortmsg = _('%s hook denied (from untrusted config)')
>
> I'm not a fan of this wording
>
> Probably "denied %s hook (....)"
>

All all test related message starts with "<hookname> hook <stuff that 
happened>" I would rather stick with that.

> > +                warnmsg = _('warning: %s hook denied (from 
> untrusted config)\n')
>

Cheers,

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list