[PATCH 3 of 3] hook: report untrusted hooks as failure (issue5110) (BC)

timeless timeless at gmail.com
Fri Apr 15 15:12:20 EDT 2016


can i convince you to replace "denied" with "skipped"?

On Fri, Apr 15, 2016 at 2:48 PM, Pierre-Yves David
<pierre-yves.david at ens-lyon.org> wrote:
>
>
> On 04/15/2016 06:26 AM, timeless wrote:
>>
>>
>>
>> On Apr 15, 2016 3:50 AM, "Pierre-Yves David"
>> <pierre-yves.david at ens-lyon.org <mailto:pierre-yves.david at ens-lyon.org>>
>> wrote:
>>
>> > +                abortmsg = _('%s hook denied (from untrusted config)')
>>
>> I'm not a fan of this wording
>>
>> Probably "denied %s hook (....)"
>>
>
> All all test related message starts with "<hookname> hook <stuff that
> happened>" I would rather stick with that.
>
>> > +                warnmsg = _('warning: %s hook denied (from untrusted
>> > config)\n')
>>
>
> Cheers,
>
> --
> Pierre-Yves David


More information about the Mercurial-devel mailing list