Making 'roll' in histedit use first commit's date

Ben Schmidt mail_ben_schmidt at yahoo.com.au
Wed Apr 20 22:01:33 EDT 2016


On 21/04/2016 11:20 am, Augie Fackler wrote:
> On Apr 20, 2016, at 6:23 PM, Matt Mackall <mpm at selenic.com> wrote:
>> I don't have a strong opinion about which way the date goes by
>> default. I do care that it agrees with commit --amend, and it
>> apparently doesn't.
>>
>> So a patch for this would probably be acceptable. But it'll have to
>> wait for the end of the 3.8 code freeze, which is May 1.
>
> I don’t feel especially strongly either. I think the logic (which is
> ~8 years old) in histedit is whenever two commits are combined, it
> picks the higher of the two dates.

Yes, I believe that's correct from when I looked at the source code
recently.

I'll prepare a patch and submit it after May 1 unless you prefer me to
submit it earlier and just review it after that date.

Ben





More information about the Mercurial-devel mailing list