[PATCH V3] shelve: restore parents after unshelve (issue5123)

[Piotr Listkiewicz]

>
> You might want consider adding a flag for this kind of patch (like WIP) to
> make sure people know what they are about.


Right, thanks for tip


> This seems to be a complicated issue and as this is not fixing a
> regression (just a bug that have always been here, right?). So I personally
> think we should defer further digging until the freeze is lifted. Piotr
> what would you think about that?


Yeah, thats the bug thats probably has always been in shelve
implementation. I agree about deferring further digging, after freeze i
will poke devs about this issue

2016-04-20 23:07 GMT+02:00 Pierre-Yves David <pierre-yves.david at ens-lyon.org
>:

>
>
> On 04/11/2016 02:30 PM, liscju wrote:
>
>> # HG changeset patch
>> # User liscju <piotr.listkiewicz at gmail.com>
>> # Date 1459461357 -7200
>> #      Thu Mar 31 23:55:57 2016 +0200
>> # Node ID aba676a11c963282ca8d14d0a25636ecb67e9b54
>> # Parent  c5565fc8848dd084d104ca40c33d1acdfcff8bc6
>> shelve: restore parents after unshelve (issue5123)
>>
>> This patch is a work in progress, it has bug and its not
>> ready to be merged into repository.
>>
>
> You might want consider adding a flag for this kind of patch (like WIP) to
> make sure people know what they are about.
>
> This seems to be a complicated issue and as this is not fixing a
> regression (just a bug that have always been here, right?). So I personally
> think we should defer further digging until the freeze is lifted. Piotr
> what would you think about that?
>
> --
> Pierre-Yves David
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160421/ff8402c9/attachment.html>