[PATCH 2 of 5 stable osx-packaging v2] osx: add support for dumping built dmg into OUTPUTDIR

Kevin Bullock kbullock+mercurial at ringworld.org
Fri Apr 29 09:58:37 EDT 2016


> On Apr 29, 2016, at 03:03, Yuya Nishihara <yuya at tcha.org> wrote:
> 
> On Wed, 27 Apr 2016 11:45:52 -0400, Augie Fackler wrote:
>> # HG changeset patch
>> # User Augie Fackler <augie at google.com>
>> # Date 1461038242 14400
>> #      Mon Apr 18 23:57:22 2016 -0400
>> # Branch stable
>> # Node ID ced65aad425150aa6d012cae692fcc1ae20f0ddc
>> # Parent  1d2e15aa68f73659a3f45907e2e035c5a3dc053b
>> osx: add support for dumping built dmg into OUTPUTDIR
>> 
>> diff --git a/Makefile b/Makefile
>> --- a/Makefile
> 
>> +	OUTPUTDIR=$${OUTPUTDIR:=packages/osx}
>> +	mkdir -p $$OUTPUTDIR
>> +	N=`cd dist && echo mercurial-*.mpkg | sed 's,\.mpkg$$,,'` && hdiutil create -srcfolder dist/$$N.mpkg/ -scrub -volname "$$N" -ov $$OUTPUTDIR/$$N.dmg
> 
> make executes /bin/sh per line, so this doesn't work. But the final "osx"
> rule at the PATCH 5 has no such problem.

Augie, since we ripped out and replaced the existing process in patch 5 anyway, should we drop patches 2 & 3 that make incremental changes to the broken way?

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock



More information about the Mercurial-devel mailing list