[PATCH] convert: move svn config initializer out of the module level

Yuya Nishihara yuya at tcha.org
Tue Aug 2 08:21:53 EDT 2016


On Mon, 1 Aug 2016 17:43:58 -0700, Durham Goode wrote:
> # HG changeset patch
> # User Durham Goode <durham at fb.com>
> # Date 1470098281 25200
> #      Mon Aug 01 17:38:01 2016 -0700
> # Node ID 8f033343d96b42e87d90cac108ef8256a0797b27
> # Parent  73ff159923c1f05899c27238409ca398342d9ae0
> convert: move svn config initializer out of the module level
> 
> The svn_config_get_config config call was being called at the module level, but
> had the potential to throw permission denied errors if ~/.subversion/servers was
> not readable. This could happen in certain test environments where the user
> permissions were very particular.

LGTM. Perhaps we'd better put the fix in stable?


More information about the Mercurial-devel mailing list