[PATCH] convert: move svn config initializer out of the module level

Augie Fackler raf at durin42.com
Tue Aug 2 10:52:29 EDT 2016


On Tue, Aug 02, 2016 at 09:21:53PM +0900, Yuya Nishihara wrote:
> On Mon, 1 Aug 2016 17:43:58 -0700, Durham Goode wrote:
> > # HG changeset patch
> > # User Durham Goode <durham at fb.com>
> > # Date 1470098281 25200
> > #      Mon Aug 01 17:38:01 2016 -0700
> > # Node ID 8f033343d96b42e87d90cac108ef8256a0797b27
> > # Parent  73ff159923c1f05899c27238409ca398342d9ae0
> > convert: move svn config initializer out of the module level
> >
> > The svn_config_get_config config call was being called at the module level, but
> > had the potential to throw permission denied errors if ~/.subversion/servers was
> > not readable. This could happen in certain test environments where the user
> > permissions were very particular.
>
> LGTM. Perhaps we'd better put the fix in stable?

Sounds fine to me. Queued for stable.


> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list