[PATCH 3 of 9] bundle2: add a devel option controling bundle version used for exchange

[Pierre-Yves David]

On 08/03/2016 05:24 PM, Gregory Szorc wrote:
>
>
>> On Aug 3, 2016, at 07:54, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
>>
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
>> # Date 1470142101 -7200
>> #      Tue Aug 02 14:48:21 2016 +0200
>> # Node ID 2a9b825514377c8486b8dbd3dfbdd865efeba1fc
>> # Parent  2d61469ee8d3af037aa4e2730576777bbe12ff57
>> # EXP-Topic bundle2.devel
>> bundle2: add a devel option controling bundle version used for exchange
>>
>> We need an official way to force bundle1 to be used in test. We introduce a new
>> option 'devel.legacy.exchange' to control this. When specified, this option
>> will control the list of bundle version Mercurial consider when exchanging with
>> a peer. Current valid value are 'bundle1' and 'bundle2'.
>
> As a follow up, you may want to hook up a way to disable the getbundle capability entirely as a way to test the ancient wire protocol commands for retrieving changegroups. I'm pretty sure our testing of those code paths is lacking.

That is the spirit of this 'legacy.xxx' series of variable. (that I 
expect to be bikesheded a bit. I'll try to remember about this getbundle 
thingy (but also feel free to jump in). But I think we have some other 
hack somewhere to test it. However, We probably wants need some 
test-runner integrated way to test variants.

Cheers,

-- 
Pierre-Yves David