[PATCH 1 of 4] py3: update test-check-py3-compat.t output

FUJIWARA Katsunori foozy at lares.dti.ne.jp
Thu Aug 4 22:41:23 EDT 2016


At Thu, 04 Aug 2016 00:48:22 +0530,
Pulkit Goyal wrote:
> 
> # HG changeset patch
> # User Pulkit Goyal <7895pulkit at gmail.com>
> # Date 1470249288 -19800
> #      Thu Aug 04 00:04:48 2016 +0530
> # Branch stable
> # Node ID 498534103bb67c47f334d84f20ced9bd5acde1aa
> # Parent  d3df009ab1175a6792549b51ae66486dd98f398b
> py3: update test-check-py3-compat.t output
> 
> The lower part of test-check-py3-compat.t runs only on py3 and hence its
>  remain unchanged. Hence this patch updates the output so that change in output
>  in the next patches will be only related to the change in the patch.
> 
> diff -r d3df009ab117 -r 498534103bb6 tests/test-check-py3-compat.t
> --- a/tests/test-check-py3-compat.t	Wed Jul 20 14:12:45 2016 -0500
> +++ b/tests/test-check-py3-compat.t	Thu Aug 04 00:04:48 2016 +0530
> @@ -136,8 +136,9 @@
>    mercurial/patch.py: error importing: <TypeError> '_fields_' must be a sequence of (name, C type) pairs (error at osutil.py:*) (glob)
>    mercurial/pathutil.py: error importing: <TypeError> '_fields_' must be a sequence of (name, C type) pairs (error at osutil.py:*) (glob)
>    mercurial/peer.py: error importing: <TypeError> '_fields_' must be a sequence of (name, C type) pairs (error at osutil.py:*) (glob)
> -  mercurial/pure/mpatch.py: error importing module: <AttributeError> 'VendorImporter' object has no attribute 'find_spec' (line *) (glob)
> -  mercurial/pure/parsers.py: error importing module: <AttributeError> 'VendorImporter' object has no attribute 'find_spec' (line *) (glob)
> +  mercurial/pure/mpatch.py: error importing module: <ImportError> cannot import name 'pycompat' (line *) (glob)
> +  mercurial/pure/osutil.py: error importing module: <ImportError> cannot import name 'policy' (line *) (glob)
> +  mercurial/pure/parsers.py: error importing module: <ImportError> No module named 'mercurial.pure.node' (line *) (glob)
>    mercurial/pushkey.py: error importing: <TypeError> '_fields_' must be a sequence of (name, C type) pairs (error at osutil.py:*) (glob)
>    mercurial/pvec.py: error importing: <TypeError> '_fields_' must be a sequence of (name, C type) pairs (error at osutil.py:*) (glob)
>    mercurial/registrar.py: error importing: <TypeError> '_fields_' must be a sequence of (name, C type) pairs (error at osutil.py:*) (glob)

Thnak you for this patch! I'm just investigating why
test-check-py3-compat.t fails only on my environment :-)

But even after this patch, test-check-py3-compat.t fails with error
below on my environment:

@@ -136,7 +136,7 @@
   mercurial/patch.py: error importing: <TypeError> getattr(): attribute name must be string (error at pycompat.py:*) (glob)
   mercurial/pathutil.py: error importing: <TypeError> getattr(): attribute name must be string (error at pycompat.py:*) (glob)
   mercurial/peer.py: error importing: <TypeError> getattr(): attribute name must be string (error at pycompat.py:*) (glob)
-  mercurial/pure/mpatch.py: error importing module: <ImportError> cannot import name 'pycompat' (line *) (glob)
+  mercurial/pure/mpatch.py: error importing module: <ImportError> cannot import name 'policy' (line 12)
   mercurial/pure/osutil.py: error importing module: <ImportError> cannot import name 'policy' (line *) (glob)
   mercurial/pure/parsers.py: error importing module: <ImportError> No module named 'mercurial.pure.node' (line *) (glob)
   mercurial/pushkey.py: error importing: <TypeError> getattr(): attribute name must be string (error at pycompat.py:*) (glob)

Would you have any suggestion for me ?

I run test-check-py3-compat.t by the command line below on the root of
Mercurial source repository with Python 3.5.2

  (cd tests && python ./run-tests.py --with-python3 `which python3` test-check-py3-compat.t)


In fact, I have the path to fix problem that mercurial/pure/*.py
causes error at relative importing only at check-py3-compat.py. But I
can't believe validity of my work, because of this unexpected failure
of test-check-py3-compat.t :-<



> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

----------------------------------------------------------------------
[FUJIWARA Katsunori]                             foozy at lares.dti.ne.jp


More information about the Mercurial-devel mailing list