[PATCH 3 of 7] statichttprepo: do not try to write caches

Gregory Szorc gregory.szorc at gmail.com
Fri Aug 5 10:23:28 EDT 2016



> On Aug 5, 2016, at 06:59, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
> 
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
> # Date 1470404889 -7200
> #      Fri Aug 05 15:48:09 2016 +0200
> # Node ID c35e9b9c8de2bde1b16c470f6d92ae5b2c258aad
> # Parent  9677e36d339bc11d8223aadd9473eb7218b8b6cb
> # EXP-Topic vfsward
> statichttprepo: do not try to write caches
> 
> The static http repository are read only, there is no hope in any cache
> writing attempt.

I think that deserves an inline comment. I could see the empty method confusing people.

> 
> diff -r 9677e36d339b -r c35e9b9c8de2 mercurial/statichttprepo.py
> --- a/mercurial/statichttprepo.py    Fri Aug 05 13:44:17 2016 +0200
> +++ b/mercurial/statichttprepo.py    Fri Aug 05 15:48:09 2016 +0200
> @@ -181,6 +181,9 @@ class statichttprepository(localrepo.loc
>     def lock(self, wait=True):
>         raise error.Abort(_('cannot lock static-http repository'))
> 
> +    def _writecaches(self):
> +        pass
> +
> def instance(ui, path, create):
>     if create:
>         raise error.Abort(_('cannot create new static-http repository'))
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list