[PATCH] worker: ensure a posix worker exits with os._exit

Jun Wu quark at fb.com
Tue Aug 9 12:19:46 EDT 2016


Excerpts from Yuya Nishihara's message of 2016-08-10 00:42:21 +0900:
> > By the way, there is a separate issue about sshpeer.cleanup: it can lead to
> > deadlock reading peer.pipee, if any other forked process keeps its pipeo
> > open at the time - thus the remote does not get EOF for its stdin and won't
> > end.
> 
> Are they daemon processes? If they aren't, we can probably expect they'll
> end soon and pipe fds will be closed.

They are workers. The deadlock was explained in the commit message of this
patch. Basically whoever calls sshpeer.cleanup may deadlock - it could be
either the worker or the master.


More information about the Mercurial-devel mailing list