[PATCH] dispatch: split global error handling out so it can be reused

Yuya Nishihara yuya at tcha.org
Thu Aug 11 04:32:03 EDT 2016


On Wed, 10 Aug 2016 15:47:34 +0100, Jun Wu wrote:
> Excerpts from Yuya Nishihara's message of 2016-08-10 23:37:29 +0900:
> > Well, that is considered a bad pattern. commandserver (and subrepo) can't
> > easily avoid import cycles because they send requests back to their upper
> > layers. There are inherently cycles.
> > 
> > But, your callcatch() could be moved to utility layer except for a few parts
> > which are tightly bound to command handling. And worker.py won't need these
> > parts.
> 
> Probably scmutil.py?

Perhaps.

> I can move it there after this commit.

Okay, queued this, thanks. I've updated test-devel-warnings.t in flight.


More information about the Mercurial-devel mailing list