[PATCH STABLE] revset: fix keyword arguments to go through optimization process

Yuya Nishihara yuya at tcha.org
Thu Aug 11 20:27:25 EDT 2016


On Thu, 11 Aug 2016 21:40:14 +0200, Pierre-Yves David wrote:
> On 08/07/2016 01:46 PM, Yuya Nishihara wrote:
> > # HG changeset patch
> > # User Yuya Nishihara <yuya at tcha.org>
> > # Date 1470549529 -32400
> > #      Sun Aug 07 14:58:49 2016 +0900
> > # Branch stable
> > # Node ID 77a733ef85bfd554ac0f5f1f9fa5a7088727ae7b
> > # Parent  b8f9cdca88077e97d4869320b9d18481fbe252ef
> > revset: fix keyword arguments to go through optimization process
> >
> > Before, a keyvalue node was processed by the last catch-all condition of
> > _optimize(). Therefore, topo.firstbranch=expr would bypass tree rewriting
> > and would crash if an expr wasn't trivial.
> 
> This seems correct to me, pushed.
> Thanks. Does this mean you use topo sorting somewhere?

No. I just found the bug while refactoring _optimize() to make my new revset
ordering series less sucky.


More information about the Mercurial-devel mailing list