[PATCH 1 of 4 RFC] pycompat: delay loading modules registered to stub

Yuya Nishihara yuya at tcha.org
Sun Aug 14 18:02:52 EDT 2016


On Sun, 14 Aug 2016 09:21:07 -0700, Gregory Szorc wrote:
> On Sun, Aug 14, 2016 at 2:33 AM, Yuya Nishihara <yuya at tcha.org> wrote:
> > # HG changeset patch
> > # User Yuya Nishihara <yuya at tcha.org>
> > # Date 1471153584 -32400
> > #      Sun Aug 14 14:46:24 2016 +0900
> > # Node ID 131cc484d7fe95d07f677c16dbb0f506847e1d38
> > # Parent  0cb2d4db308b97e8fe7faa8d45a47b228037f230
> > pycompat: delay loading modules registered to stub
> >
> > New _pycompatstub is compatible with our demandimporter. try-except is
> > replaced by version comparison because ImportError will no longer be raised
> > immediately.
> 
> Nit: I think you mean "incompatible." This patch looks good otherwise.

I wanted to say something like "new _pycompatstub works well with our
demandimporter." Can you update the commit message in flight?


More information about the Mercurial-devel mailing list