[PATCH 2 of 3 v2] graft: support grafting across move/copy (issue4028)

[Pierre-Yves David]

On 08/15/2016 07:43 PM, Gábor STEFANIK wrote:
>>> @@ -842,3 +852,24 @@
>>>    |/
>>>    o  0
>>>
>>> +Graft from behind a move or rename
>>
>> It would be nice to have a bit more documentation about what is the
>> scenario of this test. In addition using a 'hg log --graph' before the
>> graft would help seeing the big picture. It would also be a good idea to
>> reference the issue number so that people can go look at the discussion
>> if needed.
>>
>> In addition as Matt pointed, there is multiples segment that might see a
>> rename. We should get more than one test case to make sure the various
>> combination are covered.
>
> Per the wiki, even one new test is grounds for rejection ("change existing tests instead, the testsuite is slow enough already"). I'm already stretching the boundaries here, adding multiple tests would virtually guarantee that some senior developer would shoot it down for slowing down the testsuite.

That wiki page means "new test files", adding multiple related test 
cases in the same '.t' file is the recommended way. Covering all the 
facets of your changes with test case is definitly not stretching the 
boundary. It is actually recommended and would avoid senior developer 
shooting it down for lack of coverage ;-)

In addition writing these tests will help you understand the problem 
space and make sure renames in all three segments are properly tested.

Cheer,

-- 
Pierre-Yves David