[PATCH] py3: handle os.environ.get() case in module loader

Yuya Nishihara yuya at tcha.org
Thu Aug 18 04:29:58 EDT 2016


On Wed, 17 Aug 2016 10:46:01 -0700, Siddharth Agarwal wrote:
> On 8/17/16 10:21, Gregory Szorc wrote:
> > WindowsUTF8Plan has existed for years without any movement. Addressing 
> > that will require a massive refactor. Since it isn't on our radar, I 
> > think it is out of scope for Python 3 porting work. Can we just use 
> > os.environb/bytes paths on Python 3 for now and deal with Windows 
> > paths compatibility another time? Worst case this doesn't make 
> > Mercurial usable under Python 3 on Windows. I'm not sure anyone will 
> > care until Mercurial actually works with Python 3. And that's a way 
> > off. I think I'm fine kicking the can down the road to unblock the 
> > overall Python 3 porting effort.
> 
> Sure, that's fine by me (and it's not like our current behavior with 
> Python 2 is optimal either). I just wanted to flag this as a potential 
> area of concern.

Anyway, we can get back unicodes from our environb wrapper which would
probably store localstr objects, and pass them to subprocess.


More information about the Mercurial-devel mailing list