[PATCH 1 of 3] dispatch: explicitly pass fancyopts optional arg as a keyword

Augie Fackler raf at durin42.com
Thu Aug 18 16:13:32 UTC 2016


# HG changeset patch
# User Augie Fackler <augie at google.com>
# Date 1471534322 14400
#      Thu Aug 18 11:32:02 2016 -0400
# Node ID 8ed7fdc716ffc95a4062875eafc2739697122fbc
# Parent  8d226db31f20b8c4a2c119e10be7533948f0bad6
dispatch: explicitly pass fancyopts optional arg as a keyword

I've been baffled by this a couple of times (mainly wondering if any
callers of fancyopts.fancyopts that don't use gnu=True exist), so
let's just specify this as a keyword argument to preserve sanity.

diff --git a/mercurial/dispatch.py b/mercurial/dispatch.py
--- a/mercurial/dispatch.py
+++ b/mercurial/dispatch.py
@@ -556,7 +556,7 @@ def _parse(ui, args):
         c.append((o[0], o[1], options[o[1]], o[3]))
 
     try:
-        args = fancyopts.fancyopts(args, c, cmdoptions, True)
+        args = fancyopts.fancyopts(args, c, cmdoptions, gnu=True)
     except fancyopts.getopt.GetoptError as inst:
         raise error.CommandError(cmd, inst)
 


More information about the Mercurial-devel mailing list