[PATCH] localrepo: actually invalidate dirstate on invalidatedirstate()

Yuya Nishihara yuya at tcha.org
Sat Aug 27 09:43:21 EDT 2016


On Fri, 26 Aug 2016 16:12:21 +0000, Mateusz Kwapich wrote:
> So invalidate is by design not-always invalidating and it’s relying on
> filecache to actually invalidate dirstate when needed?
> Why do we even need the invalidate in this case if filecache can always
> properly invalidate dirstate?

See dca59d5be12d about the idea behind @filecache, which says "watch that
file stat info for modifications when we decide it's important for it to be
up-to-date." So invalidate() teaches filecache to compare timestamps on
the next dirstate request. In other cases, filecache simply returns a cached
object like propertycache.


More information about the Mercurial-devel mailing list