[PATCH 1 of 2] histedit: report progress from verifyactions (issue5341)
Yuya Nishihara
yuya at tcha.org
Sun Aug 28 10:28:10 EDT 2016
On Wed, 24 Aug 2016 17:31:18 +0000, timeless wrote:
> # HG changeset patch
> # User timeless <timeless at mozdev.org>
> # Date 1472058828 0
> # Wed Aug 24 17:13:48 2016 +0000
> # Node ID 7b0afc5eacdc0662ed0fcde8eb58c8e599a7f695
> # Parent b1809f5d7630a3fff0fa715bbd30dba0f07672a8
> # Available At https://bitbucket.org/timeless/mercurial-crew
> # hg pull https://bitbucket.org/timeless/mercurial-crew -r 7b0afc5eacdc
> histedit: report progress from verifyactions (issue5341)
>
> With this change, I get progress like this:
> checking [==> ] 39/726 5m01s
>
> And sadly, those time estimates are accurate.
> The verifyactions step is *much* slower than the editing stage:
> editing [===> ] 49/726 1m47s
>
> diff -r b1809f5d7630 -r 7b0afc5eacdc hgext/histedit.py
> @@ -1399,7 +1399,12 @@
> expected = set(c.hex() for c in ctxs)
> seen = set()
> prev = None
> + rulelen = len(actions)
> + i = 0
> for action in actions:
> + i += 1
could be "for i, aciton in enumerate(actions)"
> + ui.progress(_("checking"), i, 'task',
> + _('changes'), rulelen)
As Anton said, item='task' is useless and should be omitted.
More information about the Mercurial-devel
mailing list