[PATCH] update: do not remove cwd

[Stanislau Hlebik]

Yes, but it will help users of histedit, split etc.
Maybe we can even combine warning and restoring cwd.



Sent from Samsung Mobile on O2


-------- Original message --------
From: Augie Fackler <raf at durin42.com>
Date: 30/08/2016 18:51 (GMT+00:00)
To: Stanislau Hlebik <stash at fb.com>
Cc: Durham Goode <durham at fb.com>, mercurial-devel at mercurial-scm.org, Ryan McElroy <rm at fb.com>
Subject: Re: [PATCH] update: do not remove cwd

On Tue, Aug 30, 2016 at 1:41 PM, Stanislau Hlebik <stash at fb.com> wrote:
> Yeap, Augie already noted it.
> Warning is probably fine (it’s better than nothing).
> Another option is to try to save cwd before update and try to restore it after.

That won't help the user, since their cwd won't be altered by changes
made in the subprocess.

(Unless you mean "try to recreate cwd as a directory if it appears to
have been removed", in which case that *might* work, but I don't think
so because the directory's inode will change out from under the user
and I think they'll still be in a busted state.)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20160830/3a3f5421/attachment.html>