[PATCH STABLE] bundle2: localize "remote: "
Matt Mackall
mpm at selenic.com
Wed Aug 31 02:58:24 EDT 2016
On Tue, 2016-08-30 at 17:49 -0700, Gregory Szorc wrote:
> However, I'm going to posit that _() not being used was accidental. We
> translate "remote: " everywhere else. This code is running locally (not on
> the server). So I don't see why we wouldn't tranhslate.
I agree it's almost certainly wrong.
But the thing I'm getting at is:
- we've had rules forever to make sure all write/status messages get translated
- so it's weird when one isn't
- and extra weird when an obvious one like this has willfully defeated the rule
- such weirdness should trigger a higher level of investigation and rationale
When we fix things that are obviously wrong, we always risk breaking things that
are actually subtly right. A really good warning sign that we're about to do
that is when we find something that's obviously wrong.. but also inexplicable.
--
Mathematics is the supreme nostalgia of our time.
More information about the Mercurial-devel
mailing list