[PATCH 2 of 3] context: add a `blockancestors(fromline, toline)` method to filectx

Yuya Nishihara yuya at tcha.org
Fri Dec 2 09:20:27 EST 2016


On Fri, 2 Dec 2016 08:36:42 +0100, Denis Laxalde wrote:
> Yuya Nishihara a écrit :
> > On Mon, 28 Nov 2016 10:54:15 +0100, Denis Laxalde wrote:
> >> +        def changesrange(fctx1, fctx2, linerange2):
> >> +            """Return `(diffinrange, linerange1)` where `diffinrange` is True
> >> +            if diff from fctx2 to fctx1 has changes in linerange2 and
> >> +            `linerange1` is the new line range for fctx1.
> >> +            """
> >> +            diffopts = patch.diffopts(self._repo.ui)
> >
> > Is it intended to take all diff options such as ignorews?
> 
> I'd say so, at least when used from the "changes" revset. Perhaps the
> function could get an opts keyword argument and defaults to this (or
> mdiff.defaultopts maybe) if unspecified. Do you see any case where this
> wouldn't be desirable?

There's an API repo.revs() which ignores user aliases explicitly. I'm not sure
if that is the case for the changes() revset, so asked. (I don't mean changes()
should disregard diff options.)

Another question is if it should see the [diff] section, [annotate], or other?


More information about the Mercurial-devel mailing list